Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_tcp: user friendly warn message for skipping records #6061

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

PettitWesley
Copy link
Contributor

Signed-off-by: Wesley Pettit [email protected]


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@PettitWesley PettitWesley temporarily deployed to pr September 16, 2022 20:27 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 16, 2022 20:27 Inactive
@PettitWesley
Copy link
Contributor Author

@edsiper I have seen a lot of users get confused by this. At first I was going to make this a debug message, but I really strongly advocate that users need to see these messages as a warning/error/problem since FB is skipping logs.

Master PR: https://github.com/fluent/fluent-bit/pull/6062/files

https://github.com/aws/aws-for-fluent-bit/blob/mainline/troubleshooting/debugging.md#chunk_size-and-buffer_size-for-large-logs-in-tcp-input

@PettitWesley PettitWesley temporarily deployed to pr September 16, 2022 20:43 Inactive
@PettitWesley PettitWesley added this to the Fluent Bit v1.9.9 milestone Sep 16, 2022
@PettitWesley
Copy link
Contributor Author

@lecaros @edsiper CI passes. Any reason we can't merge this small usability improvement?

@PettitWesley PettitWesley temporarily deployed to pr November 14, 2022 21:30 Inactive
@PettitWesley PettitWesley temporarily deployed to pr November 14, 2022 21:30 Inactive
@PettitWesley PettitWesley temporarily deployed to pr November 14, 2022 21:45 Inactive
@edsiper edsiper merged commit c5d57cc into fluent:1.9 Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants