Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_s3: add store_dir_limit_size to limit S3 disk usage #5902

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

PettitWesley
Copy link
Contributor

@PettitWesley PettitWesley commented Aug 16, 2022

Signed-off-by: Wesley Pettit [email protected]


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Documentation

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@PettitWesley
Copy link
Contributor Author

With it we get:

[2022/08/16 21:37:27] [ warn] [output:s3:s3.0] Buffer is almost full: current_buffer_size=19483080, store_dir_limit_size=20000000 bytes
[2022/08/16 21:37:33] [error] [output:s3:s3.0] Buffer is full: current_buffer_size=19997432, new_data=41193, store_dir_limit_size=20000000 bytes

matthewfala
matthewfala previously approved these changes Aug 17, 2022
Copy link
Contributor

@matthewfala matthewfala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 21:18 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 21:20 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 21:21 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 21:22 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 21:30 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 21:30 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 21:39 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 21:39 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 21:45 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 21:45 Inactive
@PettitWesley PettitWesley reopened this Sep 9, 2022
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 21:48 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 21:48 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 21:49 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 21:49 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 22:23 Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 9, 2022 22:33 Inactive
@PettitWesley PettitWesley added this to the Fluent Bit v1.9.9 milestone Sep 16, 2022
@PettitWesley PettitWesley temporarily deployed to pr October 5, 2022 17:00 Inactive
@PettitWesley PettitWesley temporarily deployed to pr October 5, 2022 17:00 Inactive
@PettitWesley PettitWesley temporarily deployed to pr October 5, 2022 17:21 Inactive
@PettitWesley PettitWesley added AWS Issues with AWS plugins or experienced by users running on AWS and removed docs-required labels Oct 27, 2022
@PettitWesley
Copy link
Contributor Author

@PettitWesley
Copy link
Contributor Author

@edsiper Ready for merge/review.

@PettitWesley
Copy link
Contributor Author

PettitWesley commented Nov 15, 2022

@edsiper edsiper merged commit 760956f into fluent:1.9 Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWS Issues with AWS plugins or experienced by users running on AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants