-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out_s3: add store_dir_limit_size to limit S3 disk usage #5902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With it we get:
|
matthewfala
reviewed
Aug 17, 2022
matthewfala
previously approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
PettitWesley
commented
Sep 7, 2022
PettitWesley
force-pushed
the
store_dir_limit_size
branch
from
September 9, 2022 21:18
3067243
to
918bd13
Compare
PettitWesley
force-pushed
the
store_dir_limit_size
branch
from
September 9, 2022 21:20
918bd13
to
f3783aa
Compare
PettitWesley
force-pushed
the
store_dir_limit_size
branch
from
September 9, 2022 21:47
6128362
to
67e51d3
Compare
Signed-off-by: Wesley Pettit <[email protected]>
PettitWesley
force-pushed
the
store_dir_limit_size
branch
from
October 5, 2022 16:39
67e51d3
to
fa45e91
Compare
PettitWesley
added
AWS
Issues with AWS plugins or experienced by users running on AWS
and removed
docs-required
labels
Oct 27, 2022
@edsiper Ready for merge/review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wesley Pettit [email protected]
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
Documentation
https://github.com/fluent/fluent-bit-docs/pull/956/files
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.