Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove corrupted input chunk on flush #5858

Closed
wants to merge 1 commit into from

Conversation

bgaifullin
Copy link

The error CIO_CORRUPTED does not handle in flush method and fluent-bit stops processing logs if it meets corrupted file.
The patch tries to handle this case by silently removing corrupted chunk.

Addresses #4278


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@JeffLuoo
Copy link
Contributor

JeffLuoo commented Sep 1, 2022

I'm kinda confused as the CIO_CORRUPTED is checked when the function sb_segregate_chunks is executed: https://sourcegraph.com/github.com/fluent/fluent-bit@0336dc63d3358db77c1f35dd15dc87ad368d2edb/-/blob/plugins/in_storage_backlog/sb.c?L354. Do you mind sharing your chunk to reproduce the issue?

Edit: Went back and found that you're referring to a different error than I thought about could not segregate backlog chunk but #4278 (comment).

@bgaifullin
Copy link
Author

Unfortunately I cannot share chunk.
I can try to collect another kind of information, if you need.

@tarruda
Copy link

tarruda commented Sep 9, 2022

There was a recent chunkio refactor (#5753 for details). @bgaifullin can you check if this issue is still relevant?

@bgaifullin
Copy link
Author

Ok, I will check.
Thank you.

@bgaifullin
Copy link
Author

Seems like version 1.9.9 works fine.
Thank you

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jan 4, 2023
@bgaifullin bgaifullin closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants