build: CMakeLists.txt Do not use private makefile targets

[ptsneves]

$< is a private detail from the Makefile generated by CMakefile and
are not under control or to be used at the CMakeLists level. In 3.20
that private generation changed pre-requisite targets[1] and now logs
contain the path compiler_depend.ts instead of the actual file.

Fixes #5492

---

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

• [ N/A ] Example configuration file for the change
• [ N/A ] Debug log output from testing the change

• [ N/A ] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

• [ N/A ] Attached local packaging test output showing all targets (including any new ones) build.

Documentation

• [ N/A ] Documentation required for this feature

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

[ptsneves]

Not sure what is the issue with the commit message. How can i get a diagnostic besides to read the commit message guidelines?

[patrick-stephens]

The commit message is fine but it's not signed off: https://github.com/fluent/fluent-bit/runs/7628179973

Basically needs the signed off by bit at the bottom.

[patrick-stephens]

Ah, @ptsneves the commit and PR message checker does not like the special characters you have $< I think in it's regex.

Checking commit messages against "^[a-z0-9A-Z\-_\s\,\.\/]+\:[ ]{0,1}[a-zA-Z]+[a-zA-Z0-9 \-\.\:_\#\(\)=\/'\"\,><\+\[\]\!\*\\]+$"...
- failed: "build: CMakeLists.txt Do not use private makefile $< target"

Can you just update it slightly (and the PR title to match) to remove it?

[ptsneves]

ping

[niedbalski]

LGTM

[nokute78]

@ptsneves
This patch causes below redefined warnings.
Could you check make clean && make ?

I confirmed https://github.com/fluent/fluent-bit/tree/fc325524d50fe179b76f127243ab9e03ddbdaaa4 is reported warnings.
I also confirmed previous commit https://github.com/fluent/fluent-bit/tree/1aae9362a7bec2ce67c62b6cba6cd8cccce774df is not reported.

[ 15%] Built target chunkio-static
[ 15%] Building C object lib/monkey/deps/rbtree/CMakeFiles/rbtree.dir/rbtree.c.o
<command-line>: warning: "__FILENAME__" redefined
<command-line>: note: this is the location of the previous definition
[ 15%] Linking C static library ../../library/librbtree.a
[ 15%] Built target rbtree
[ 15%] Building C object lib/monkey/deps/regex/CMakeFiles/regex.dir/re.c.o
<command-line>: warning: "__FILENAME__" redefined
<command-line>: note: this is the location of the previous definition
[ 15%] Linking C static library ../../library/libregex.a
[ 15%] Built target regex
[ 15%] Building C object lib/monkey/deps/flb_libco/CMakeFiles/co.dir/libco.c.o
<command-line>: warning: "__FILENAME__" redefined
<command-line>: note: this is the location of the previous definition
[ 15%] Linking C static library ../../library/libco.a
[ 15%] Built target co
[ 15%] Building C object lib/monkey/mk_core/CMakeFiles/mk_core.dir/mk_rconf.c.o
<command-line>: warning: "__FILENAME__" redefined
<command-line>: note: this is the location of the previous definition
[ 15%] Building C object lib/monkey/mk_core/CMakeFiles/mk_core.dir/mk_string.c.o
<command-line>: warning: "__FILENAME__" redefined
<command-line>: note: this is the location of the previous definition
[ 15%] Building C object lib/monkey/mk_core/CMakeFiles/mk_core.dir/mk_memory.c.o
<command-line>: warning: "__FILENAME__" redefined
<command-line>: note: this is the location of the previous definition
[ 15%] Building C object lib/monkey/mk_core/CMakeFiles/mk_core.dir/mk_event.c.o
<command-line>: warning: "__FILENAME__" redefined
<command-line>: note: this is the location of the previous definition