out_stackdriver: use the correct project ID #2608
Conversation
StevenYCChou
requested review from
edsiper,
fujimotos and
koleini
as code owners
The value for project ID of monitored resources of a LogEntry should be project ID, not the project number, which is in numeric format. The value of the project ID of Cloud Logging's Monitored Resources are documented in https://cloud.google.com/logging/docs/api/v2/resource-list. The project ID to be retrived from instance metadata is documented in https://cloud.google.com/compute/docs/storing-retrieving-metadata#default. Signed-off-by: Yen-Cheng Chou <[email protected]>
StevenYCChou
force-pushed
the
correct-project-id-implementation
branch
from
8295b97 to
9a7689d
Compare
|
thanks |
|
@edsiper - Is there a scheduled release any time soon that may contain this fix? |
|
Oct 5 (v1.6)
…On Mon, Sep 28, 2020, 19:34 Ling Huang ***@***.***> wrote:
@edsiper <https://github.com/edsiper> - Is there a scheduled release any
time soon that may contain this fix?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2608 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC2INRZ5ZOSEXOC3YW3ZWTSIE2QZANCNFSM4R46GIEQ>
.
|
|
I thought the PR would be merged after it passes the tests - but I just realized this PR was merged and introducing a test failure. The test failure introduced in this PR should be fixed in #2611. @edsiper can you take a look on #2611 so we can close the loop of this PR? Also a side note - I'd like to add note to the users of stackdriver output plugin as even the project ID should be the one proposed in this PR, it would be an incompatible change for the users, so users should be aware of it. |
|
@StevenYCChou it should! but I did a bad assumption about a known Travis problem, sorry about that. #2611 is already merged. |
|
@edsiper - Hi, just checking in for the Fluent Bit 1.6 release status. Is it still scheduled for this week? |
|
@qingling128 yes, Thursday 08 |
|
Great. Thanks for the heads up! |
|
@edsiper - it seems that the head of master branch passes all the tests. Is it scheduled to be released today? If not, do you recommend using source code from the commit which passes all the tests? Just wonder whether there are other sets of tests would be run before the maintainers publish an official release. |
|
the release is under process now... |
The value for project ID of monitored resources of a LogEntry should be
project ID, not the project number, which is in numeric format.
The value of the project ID of Cloud Logging's Monitored Resources are
documented in
https://cloud.google.com/logging/docs/api/v2/resource-list.
The project ID to be retrived from instance metadata is documented in
https://cloud.google.com/compute/docs/storing-retrieving-metadata#default.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Documentation
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.