Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support new CallParameters and generate particle token [NET-767] #2099

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

kmd-fl
Copy link
Contributor

@kmd-fl kmd-fl commented Feb 21, 2024

BEGIN_COMMIT_OVERRIDE
feat: support new CallParameters and generate particle token [NET-767]
END_COMMIT_OVERRIDE

Description

Support new CallParameters and generate particle token

Motivation

We need this to secure the Particle Vault. The particle token will be used in the vault path, ensuring that no one will know about it.

Proposed Changes

  • Use new CallParameters
  • Generate particle tokens using the host's private key
  • Make the token a part of ParticleParams

Additional Notes

  1. I generate the token on ParticleParams creation since I don't see a better place where we have all the keys (don't have them in ParticleAppService, and, I guess, we don't need it there)
  2. I don't understand what to do with that call_function function. It's used by the system-service deployer and by nox when it communicates with the spell service to set trigger info, update counter, and so on.

Copy link

linear bot commented Feb 21, 2024

@kmd-fl kmd-fl added the e2e Run e2e workflow label Feb 21, 2024
@folex folex merged commit 179d697 into master Feb 21, 2024
15 checks passed
@folex folex deleted the support-new-call-params branch February 21, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants