-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(particle-vault)!: introduce new particle vault path format #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmd-fl
changed the title
feat(particle-vault): secure vault
feat(particle-vault): introduce new particle vault path format
Feb 21, 2024
kmd-fl
changed the title
feat(particle-vault): introduce new particle vault path format
feat(particle-vault)!: introduce new particle vault path format
Feb 21, 2024
folex
reviewed
Feb 22, 2024
folex
reviewed
Feb 23, 2024
kmd-fl
commented
Feb 23, 2024
folex
reviewed
Feb 23, 2024
folex
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce new particle vault features: new path format and write-only
/tmp/vault
Motivation
Need to secure the particle vault to prevent unauthorized access to the vaults of others since we map shared vault directory into services (due to marine limitation)
Proposed Changes
worker-id
(host-id
on host) as a part of the particle vault name/tmp/vault -> vault_dir/$worker_id
particle_token
in Actor to be able to clean the vault (:c)/tmp/vault/$particle-id-$particle-token/
Additional Notes
TODO:
ls
problem:- I created a simple service that does
fs::read_dir("/tmp/vault")
, it returned Permission denied.- I tried to call
set_readonly("/tmp/vault", ..)
, and the result was the error:operation not supported on this platform
- I tried to use PermissionsExt to use
chmod
directly, and it didn't compile. So, it seems impossible to change permissions inside the service.- Also,
ls
andchmod
commands are considered mounted binaries so they won't be accessible.