Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mishandling of downward count of numchannels in arrays #17

Closed
tremblap opened this issue Jan 17, 2022 · 3 comments · Fixed by #21
Closed

mishandling of downward count of numchannels in arrays #17

tremblap opened this issue Jan 17, 2022 · 3 comments · Fixed by #21
Assignees
Labels
invalid This doesn't seem right

Comments

@tremblap
Copy link
Member

When one runs a process and decides to only take one channel of output, it seems that the (simulated) multichannel array check is not considering the destination channel count to allow a single array to be given as a destination.

In the attached example, which needs the fluid.bufpitch help patch to run, the stats are run only on the first channel of the bufpitch-feats multiarray by specifying -numchannels 1 - yet we get an error that is slightly comical:

Not enough arrays to operate on pitchstats. Found 2 array(s) but need 1.

bug.pd.zip

@tremblap tremblap assigned tremblap and weefuzzy and unassigned tremblap Jan 18, 2022
@weefuzzy weefuzzy added the invalid This doesn't seem right label Jan 23, 2022
@weefuzzy
Copy link
Member

The attribute is -numchans not -numchannels

@weefuzzy
Copy link
Member

Although it would be good if the error message made sense

weefuzzy added a commit to weefuzzy/flucoma-pd that referenced this issue Jan 23, 2022
@weefuzzy weefuzzy mentioned this issue Jan 23, 2022
@tremblap
Copy link
Member Author

oops. sorry for the wrong bug report

jamesb93 pushed a commit that referenced this issue Feb 21, 2022
* nightlies workflow

* use PD_PATH flag

* use the pd binaries on msp

* dont use powershell in unix

* fix borked ls

* point to the right sdk

* make release builds on windows

* remove pdb file filter

* use dev core

* delete release before uploading the new one

* abstraction added to convert string back to float

* giving credit (#11)

* rename tag

* provide the proper fluid path for mac builds

* provide the proper fluid path for the other 2 CCE's

* clone core not sc... 🤦‍♂️

* Add handling for MLP read methods to wrapper (#10)

* cleaned structure and copy of abstractions

* add docs to PD CI

* add pd path

* use a macos runner for docs

* correct the name for Windows .zip

* [CI] Refactor and use composite actions (#13)

* use flucoma actions instead of horrid code

* use more composite actions where possible

* remove extraneous -name:

* try a different folder structure out

* move one level up for packaging

* demoaudiofiles abstraction for the helpfiles

* added fluid.demosound~

* move to v4 of actions

* also update docs

* cosmetic changes to improve readability

* chroma help update

* remove weird magic number fixes #18

* correct order of variables in PDBufferAdaptor error message fixes #17

* corrections in progress

* chroma new format

* bufchroma done

* changing spaces for underlines for enhanced readability

* use new action for building docs

* use ubuntu to build docs

* update release workflow

* add support for core #88

* copy to datasets path

* ignore data

* copy resources data on cmake configure

* change source1 to sourcea and source2 to sourceb

* add workflow dispatch to nightly
jamesb93 pushed a commit that referenced this issue Mar 30, 2022
* nightlies workflow

* use PD_PATH flag

* use the pd binaries on msp

* dont use powershell in unix

* fix borked ls

* point to the right sdk

* make release builds on windows

* remove pdb file filter

* use dev core

* delete release before uploading the new one

* abstraction added to convert string back to float

* giving credit (#11)

* rename tag

* provide the proper fluid path for mac builds

* provide the proper fluid path for the other 2 CCE's

* clone core not sc... 🤦‍♂️

* Add handling for MLP read methods to wrapper (#10)

* cleaned structure and copy of abstractions

* add docs to PD CI

* add pd path

* use a macos runner for docs

* correct the name for Windows .zip

* [CI] Refactor and use composite actions (#13)

* use flucoma actions instead of horrid code

* use more composite actions where possible

* remove extraneous -name:

* try a different folder structure out

* move one level up for packaging

* demoaudiofiles abstraction for the helpfiles

* added fluid.demosound~

* move to v4 of actions

* also update docs

* cosmetic changes to improve readability

* chroma help update

* remove weird magic number fixes #18

* correct order of variables in PDBufferAdaptor error message fixes #17

* corrections in progress

* chroma new format

* bufchroma done

* changing spaces for underlines for enhanced readability

* use new action for building docs

* use ubuntu to build docs

* update release workflow

* add support for core #88

* copy to datasets path

* ignore data

* copy resources data on cmake configure

* change source1 to sourcea and source2 to sourceb

* add workflow dispatch to nightly

* correct docs install source

* fix the missing ; at the end of the updated file names

* Add feature objects for slicers (#35)

* Add feature objects for slicers

* onsetfeature help file

* rt feature help files

* remove thing about pianos

* add buffer feature help files

* @Algorithm

* fixing the helpfiles

* expanded onsetfeature

* norveltyfeature fixed

* ampfeature fixed

* fixed bufampfeature

* bufnoveltyfeature corrected

* fix bufonsetfeature

* corrected range for onsetfeature viewer
jamesb93 pushed a commit that referenced this issue Jun 14, 2022
* nightlies workflow

* use PD_PATH flag

* use the pd binaries on msp

* dont use powershell in unix

* fix borked ls

* point to the right sdk

* make release builds on windows

* remove pdb file filter

* use dev core

* delete release before uploading the new one

* abstraction added to convert string back to float

* giving credit (#11)

* rename tag

* provide the proper fluid path for mac builds

* provide the proper fluid path for the other 2 CCE's

* clone core not sc... 🤦‍♂️

* Add handling for MLP read methods to wrapper (#10)

* cleaned structure and copy of abstractions

* add docs to PD CI

* add pd path

* use a macos runner for docs

* correct the name for Windows .zip

* [CI] Refactor and use composite actions (#13)

* use flucoma actions instead of horrid code

* use more composite actions where possible

* remove extraneous -name:

* try a different folder structure out

* move one level up for packaging

* demoaudiofiles abstraction for the helpfiles

* added fluid.demosound~

* move to v4 of actions

* also update docs

* cosmetic changes to improve readability

* chroma help update

* remove weird magic number fixes #18

* correct order of variables in PDBufferAdaptor error message fixes #17

* corrections in progress

* chroma new format

* bufchroma done

* changing spaces for underlines for enhanced readability

* use new action for building docs

* use ubuntu to build docs

* update release workflow

* add support for core #88

* copy to datasets path

* ignore data

* copy resources data on cmake configure

* change source1 to sourcea and source2 to sourceb

* add workflow dispatch to nightly

* correct docs install source

* optional args: add to wrapper

* Wrapper: Add choices param (symbol list -> bitset)

* fix the missing ; at the end of the updated file names

* Add feature objects for slicers (#35)

* Add feature objects for slicers

* onsetfeature help file

* rt feature help files

* remove thing about pianos

* add buffer feature help files

* @Algorithm

* fixing the helpfiles

* expanded onsetfeature

* norveltyfeature fixed

* ampfeature fixed

* fixed bufampfeature

* bufnoveltyfeature corrected

* fix bufonsetfeature

* corrected range for onsetfeature viewer

* ignore more permutations of build folder

* PDWrapper: deal with some warnings

* FluidTensorView copy updates

* changing preset and interface for noveltyslice examples

* new overview including all data objects

* PDBufferAdaptor: Add redraw() and call on release()

* remove the data folder being copied in the dev packaging (#27)

* concataudiofile and it help merged in dev

* `ControlIn` objects
– properly adjust `ac` when adjusting `av` 
– ensure mListSize is always intialized to something

* Enhance/max params (#44)

* CMake: Centralise C++ version and set to 17

* Wrapper: Handle new LongRuntimeMax parameter type

* Wrapper: unused variable

* Wrapper: add `max<blah>` parameter to PD object for `LongRuntimeMaxT` 

fixes #45

* updated helpfiles for scalers to include and test inversetransform(point)

* Wrapper: fix argument count and warning printer

* Wrapper: update for `maxFFTSize`

* Wrapper: fix reset for shared objects

* Wrapper: use raw maxFFT in FFT setter

* Wrapper: fix logic for max params

* Wrapper: sort max FFT logic, fixes #48

* Enhance/generate stubs (#49)

* CMake: Generate .cpp stubs

* CMake remove old cpp stubs and scripts

* CMake add Utiltiy for making a working folder of symlinks for dev work

* Placate MSVC

* CMake: properly invoke docs

* CMake: install prefix is a cache variable

* CMake: Tidy up

* CMake: typo

* CI: update nightly workflow

* CI: remember to use correct branches

* CI: remove reference to docs job

* CMake: belatedly add branch selection for flucoma deps upon which CI relies

* CI: Correct name of Linux build artefact

* help upgrade: first batch Martin

* help upgrade: Martin's 2nd batch

* help review: martin 3rd batch

* help - typo in filename

* CMake: fix installation path for externals, fixes #50

Repeat after me: don't just paste from the Max one

* CMake: Pick up client tags for finer tilde control

* Enhance/managed objects (#47)

* Wrapper: Add managed buffers and message outptus

* Wrapper: Update outlets for list input

* Wrapper: Fix outlet reference for buffer completion

* Add header for bufinfo

* Add C++ stub for bufinfo

* Managed arrays: shrink collection when needed

* Update include/FluidPDWrapper.hpp

Remove leftover debugging `post()`

* BufferAdaptor: Ensure dirty flag is properly initialised

* Wrapper: Stop hosted buffers vector reallocating and breaking pointers

* updated helpfiles for new interface

* bufinfo help

* PD Wrapper: Quite possibly fix a double free problem for multiple inlets.

* PDWrapper: data objects respond from right outlet for read, write etc

* dataset objects: update with right outlet behaviour

Co-authored-by: tremblap <[email protected]>

* Wrapper: Cheer up MSVC

* PDWrapper: Try to swerve around GCC linking sadness

* CMake: Add local target for `fluid.bufinfo`

* FluidBufInfo: Missing include

* PDWrapper: Redo inlet proxies for less crashing

* kdtree - added 2nd tab

* kdtree 3rd tab added

* kdtree fix

* BufNNDSVD -> BufNMFSeed (#57)

* change filename

* change content

* typo in help report of bufferadaptor

* token skmeans entry and addition to overview (#59)

* [Enhance] Update Release Workflow (#60)

* update extension to be normalised

* cleanup

* update release

* remove workflow disptach variables

* fix release

* Update release.yml

* Update release.yml

* Update release.yml

* Update release.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants