fix: make sure all the dependencies are checked when flattening the d…

[danionescu]

…ependencies tree (#103)

This needs more testing. For example, my own project, I am getting the error Error: Cannot find module 'source-map-support/register', which I have seen before my fix.

[samchungy]

Would a package version affect the dependencies we need?

Eg. If one package had

[email protected] as a dep

And then another had

[email protected] as a dep

[danionescu]

I am not sure how that would work with the current code. I pushed another commit that saves the dependencies for each version.

[samchungy]

I am not sure how that would work with the current code. I pushed another commit that saves the dependencies for each version.

Neither tbh, was just curious if you knew aha 😅

[danionescu]

Lol, I took a bottom up approach to fixing this, assuming the rest of the code is correct, so I just tried to add the pieces that were missing in this place. I would need to study the rest of the code to make sure it is correct, but I don't think that I will have the time soon.

[samchungy]

This looks good to me. Thanks for the contribution @danionescu! Sorry it took so long to review. Been very busy 😮‍💨

I answered my above question with this helpful medium article. https://medium.com/learnwithrahul/understanding-npm-dependency-resolution-84a24180901b

I did give this a run locally and it lgtm. It brings across the correct dependencies.

[samchungy]

@olup @floydspace want to give this a final look?

[floydspace]

I pushed the button, thank you @danionescu @samchungy

[github-actions]

🎉 This PR is included in version 1.23.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀