Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg?.context is not a function after 491 and 492 commits #493

Closed
njculpin opened this issue Sep 20, 2023 · 2 comments · Fixed by #494
Closed

pkg?.context is not a function after 491 and 492 commits #493

njculpin opened this issue Sep 20, 2023 · 2 comments · Fixed by #494
Assignees
Labels
bug Something isn't working released

Comments

@njculpin
Copy link

njculpin commented Sep 20, 2023

Describe the bug
Since 9/19 builds now produce error:
TypeError: pkg?.context is not a function
.../serverless-esbuild/src/bundle.ts:104:46)
.../node_modules/p-map/index.js:57:22

i believe it's related to the two commits in the last 24 hours:
0d53683
36ef92e

Expected Result
This should build properly.

Reproduce
"Serverless Package" to reproduce locally

Here is my package.json:
{
"name": "manage-api",
"version": "1.0.0",
"description": "Serverless aws-nodejs-typescript template",
"main": "serverless.ts",
"scripts": {
"test": "echo "Error: no test specified" && exit 1"
},
"engines": {
"node": ">=14.15.0"
},
"dependencies": {
"@middy/core": "^2.5.3",
"@middy/http-json-body-parser": "^2.5.3",
"@shelf/dynamodb-parallel-scan": "^3.3.0",
"axios": "^0.27.2",
"csvtojson": "^2.0.10",
"dayjs": "^1.11.6",
"find-color": "^0.1.0",
"gql-query-builder": "^3.8.0",
"json2csv": "^5.0.7",
"lodash": "^4.17.21",
"os": "^0.1.2",
"path": "^0.12.7",
"request": "^2.88.2",
"sharp": "^0.31.1",
"uuid": "^9.0.0"
},
"devDependencies": {
"@serverless/typescript": "^3.0.0",
"@types/aws-lambda": "^8.10.71",
"@types/node": "^14.18.51",
"esbuild": "^0.14.54",
"json-schema-to-ts": "^1.5.0",
"serverless": "^3.0.0",
"serverless-dynamodb-local": "^0.2.40",
"serverless-esbuild": "^1.48.2",
"serverless-offline": "^10.1.0",
"serverless-plugin-split-stacks": "^1.11.3",
"ts-node": "^10.4.0",
"tsconfig-paths": "^3.9.0",
"typescript": "^4.1.3"
},
"author": "The serverless webpack authors (https://github.com/elastic-coders/serverless-webpack)",
"license": "MIT"
}

Temp Fix
Forced previous version prior to change.

@floydspace
Copy link
Owner

Thank you @njculpin for raising it, I made a silly mistake in the previous fix.
I admit we have a test coverage issue

@github-actions
Copy link

🎉 This issue has been resolved in version 1.48.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants