Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --no-build for package and deploy #338

Closed
martinmicunda opened this issue Jul 17, 2022 · 1 comment
Closed

Support --no-build for package and deploy #338

martinmicunda opened this issue Jul 17, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@martinmicunda
Copy link

martinmicunda commented Jul 17, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
The serverless-webpack has option to use --no-build flag so we can run npx sls webpack that build webpack contents and then run sls deploy --no-build -stage qa that should package and deploy the serverless service using the existing .webpack contents

Describe the solution you'd like
This is the PR that was raised for serverless-webpack. The advantage to use --no-build is for CI/CD where we can create single zip file and deploy the zip to each env.

  1. sls package --package ./dist
  2. sls deploy --no-build --stage qa (this command still generate cloudformation-template-update-stack.json and serverless-state.json files but it uses .zip file generated in step 1)
@martinmicunda martinmicunda added the enhancement New feature or request label Jul 17, 2022
@martinmicunda martinmicunda mentioned this issue Jul 22, 2023
Open
Gleeble added a commit to Gleeble/serverless-esbuild that referenced this issue Aug 19, 2023
@Gleeble
feat(issue floydspace#338): updated build process to allow for skippi…
c410d12 
…ng rebuilding of archives
Gleeble added a commit to Gleeble/serverless-esbuild that referenced this issue Aug 21, 2023
@Gleeble
feat(issue floydspace#338): renamed some properties, added readme doc…
c1ab906 
…umentation, added tests
floydspace added a commit that referenced this issue Sep 13, 2023
@floydspace
Merge pull request #484 from Gleeble/master
d445649 
Issue #338 - Added support to skip rebuilding artifacts and just regenerate cloudformation content
@floydspace
Copy link
Owner

Seems like closed

alexwillingham added a commit to alexwillingham/serverless-esbuild that referenced this issue May 9, 2024
@alexwillingham
fix(bundle): adapted proposal from issue floydspace#338 to fix memory…
235d7cb 
… leak when skipRebuild is true
floydspace pushed a commit that referenced this issue Oct 29, 2024
@alexwillingham
fix(bundle): adapted proposal from issue #338 to fix memory leak when…
4a66070 
… skipRebuild is true (#540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinmicunda @floydspace