Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Repl Multi-Expression Prompts Are Still a Problem #722

Merged

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented Mar 14, 2024

No description provided.

from [this situation](#718 (comment)), good job us
@Ellpeck Ellpeck linked an issue Mar 14, 2024 that may be closed by this pull request
@Ellpeck
Copy link
Member Author

Ellpeck commented Mar 14, 2024

Is this an acceptable way to deal with this issue? Strings are still left quoted for all REPL commands, but commands can then unquote them if they need them to be. I think this is the.. safest option? Maybe?

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.85%. Comparing base (baaa07a) to head (2d03666).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #722   +/-   ##
=======================================
  Coverage   70.85%   70.85%           
=======================================
  Files         217      217           
  Lines        7074     7074           
  Branches     1096     1096           
=======================================
  Hits         5012     5012           
  Misses       1769     1769           
  Partials      293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce
Copy link
Member

I think they are fine

@Ellpeck Ellpeck marked this pull request as ready for review March 14, 2024 13:50
@EagleoutIce EagleoutIce merged commit eedf276 into main Mar 15, 2024
22 checks passed
@EagleoutIce EagleoutIce deleted the 693-bug-repl-multi-expression-prompts-are-still-a-problem branch March 15, 2024 09:32
@EagleoutIce
Copy link
Member

This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Repl Multi-Expression Prompts Are Still a Problem
2 participants