Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-fix: don't sum ultimate stats #721

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented Mar 14, 2024

No description provided.

@Ellpeck Ellpeck linked an issue Mar 14, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.85%. Comparing base (517dd18) to head (b830871).

Files Patch % Lines
.../util/summarizer/benchmark/second-phase/process.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #721      +/-   ##
==========================================
- Coverage   70.85%   70.85%   -0.01%     
==========================================
  Files         217      217              
  Lines        7075     7074       -1     
  Branches     1096     1096              
==========================================
- Hits         5013     5012       -1     
  Misses       1769     1769              
  Partials      293      293              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce EagleoutIce merged commit baaa07a into main Mar 14, 2024
22 checks passed
@EagleoutIce EagleoutIce deleted the 720-bug-benchmarks-sum-some-fields branch March 14, 2024 09:21
@Ellpeck
Copy link
Member Author

Ellpeck commented Mar 14, 2024

hmm it seems like something is still being summarized? I'm not sure if that's to be expected or not, but it's also not a clean multiple of the previous amount.

@EagleoutIce
Copy link
Member

This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Benchmarks sum some fields
2 participants