Improve dependency management for flowr #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(to avoid webpack freaking out)
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #714 +/- ##
=======================================
Coverage 71.13% 71.13%
=======================================
Files 217 217
Lines 7033 7033
Branches 1095 1095
=======================================
Hits 5003 5003
Misses 1738 1738
Partials 292 292 ☔ View full report in Codecov by Sentry. |
Ellpeck
changed the title
|
There doesn't appear to be a rule for not preferring the |
Closed
EagleoutIce
deleted the
711-bug-importing-dfgraph-from-npm-module-causes-errors
branch
|
This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently webpack, in its infinite wisdom, thinks
node:readlinemeans "readline is to be found by using the protocolnode://", which is.. what.But alas,
node:is a redundant prefix so we just remove it. That should fix it. Apparently. I'm going to cry.