-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Dataflow Tests #665
Conversation
Looks great so far! Hopefully, I will be able to take a closer look in roughly 12-14 hours! Thank you very much for your great work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some time to review the current changes :)
Thank you very much!
test/functionality/dataflow/processing-of-elements/functions/function-call-tests.ts
Outdated
Show resolved
Hide resolved
Added explicitly instead of adding methods. Also fix node types in method signatures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for switching to the builder layer!
Dataflow graph building itself has been simplified. However, defining/using references and environments still is comparatively cumbersome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not able to find an error in the updated tests!
This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)). |
1 similar comment
This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)). |
Closes #158, when merged.