Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a startup configuration file for flowr #651

Merged
merged 16 commits into from
Feb 16, 2024

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented Feb 7, 2024

No description provided.

@Ellpeck Ellpeck linked an issue Feb 7, 2024 that may be closed by this pull request
1 task
@Ellpeck Ellpeck marked this pull request as ready for review February 7, 2024 10:25
@Ellpeck
Copy link
Member Author

Ellpeck commented Feb 7, 2024

I can't really put this to use yet because #609 hasn't been merged yet :(

@Ellpeck Ellpeck marked this pull request as draft February 7, 2024 10:26
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (dc6d0ce) 71.65% compared to head (4b6ce40) 71.60%.

Files Patch % Lines
src/config.ts 65.85% 13 Missing and 1 partial ⚠️
src/dataflow/internal/process/functions/source.ts 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
- Coverage   71.65%   71.60%   -0.06%     
==========================================
  Files         218      219       +1     
  Lines        7095     7142      +47     
  Branches     1097     1103       +6     
==========================================
+ Hits         5084     5114      +30     
- Misses       1722     1737      +15     
- Partials      289      291       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/flowr.ts Outdated Show resolved Hide resolved
src/flowr.ts Outdated Show resolved Hide resolved
@Ellpeck
Copy link
Member Author

Ellpeck commented Feb 15, 2024

I DID IT MOM MAIN IS HERE WITHOUT A MILLION COMMITS BEING MADE PART OF THE PR

@Ellpeck Ellpeck marked this pull request as ready for review February 15, 2024 10:16
src/config.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
src/config.ts Show resolved Hide resolved
src/config.ts Show resolved Hide resolved
src/dataflow/internal/process/functions/source.ts Outdated Show resolved Hide resolved
src/flowr.ts Outdated Show resolved Hide resolved
@EagleoutIce EagleoutIce merged commit 1c4bda9 into main Feb 16, 2024
21 checks passed
@EagleoutIce EagleoutIce deleted the 642-add-a-startup-configuration-file-for-flowr branch February 16, 2024 12:33
@EagleoutIce
Copy link
Member

This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)).

1 similar comment
@EagleoutIce
Copy link
Member

This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a startup configuration file for flowr
2 participants