Don't load Flow if a .flowconfig cannot be found

[orta]

Before loading up the extension it will do a check from the workspace root. To my knowledge there is no way to declare a .flowconfig in a subfolder of your project, so this should be fine. ( @gabelevi can you confirm? )

@Gozala wanna give it a review?

fixes #81

[orta]

This ends up in the vscode developer tools web inspector, which is better than nothing IMO.

[gabelevi]

I think sometimes people have something a src/ directory and then have src/.flowconfig. So I'm not sure if calling findFlowConfigDir() from the root will be a complete check.

[orta]

That's a good point, yeah.

I think the feature is important, think it's worth globing all folders ( removing any node_modules ) and look through all of those too?

[Gozala]

Before loading up the extension it will do a check from the workspace root. To my knowledge there is no way to declare a .flowconfig in a subfolder of your project, so this should be fine. ( @gabelevi can you confirm? )

@Gozala wanna give it a review?

• This seems to conflict with Add try / playground support #84 as it treats buffers / tabs with @flow pragma in js mode as flowtype.org/try editors. I often times fire up new vscode window and unsaved tab to prototype things up & I don't even have workspace setup.

• What if .flowconfig is added afterwards ? It seems that you'd need to reload window to get the plugin loaded.

• Also I often do have .flowconfig under project subdir, sometimes even multiple one of them for example: ./server/.flowconfig and ./client/.flowconfig.

I am not entirely sure what exactly happens during activation, but as far as I can tell flow server isn't actually started until qualified file is loaded, so I'm not exactly sure what's being fixed here.

fixes #81

[orta]

The issue is that it does an annoying popup in any workspace the first time you click on a JavaScript file when there's no Flow connection, perhaps tying that popup to not loading up the server.

[orta]

I think I could replace this with a much simpler "is this a typescript project?" check (which is the only time I don't want to be running Flow basically)

[orta]

What I ended up doing instead of this PR, for my own setup:

• In my personal VS Code settings, turn off flow
• In my flow repos, add a .vscode/settings.json to turn it on

[xzilja]

This issue happens a lot when "flow.useNPMPackagedFlow": true is present, it shows flow error in projects that don't have .flowconfig file.

[karlhorky]

@orta @gabelevi Is it possible this feature could still be implemented in some form? If it's not bulletproof, maybe behind an option?

[gaastonsr]

This is so needed.

[orta]

Maybe it could be an option like how prettier-vscode does - which would only make it run if there was a flowconfig in the root. I'd recommend implementing it yourself, so maybe I should just close this PR rather than have it hanging around stopping other contributors from taking a shot at the problem.