Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time-Space Diagram greyed regions #989

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Time-Space Diagram greyed regions #989

merged 2 commits into from
Jul 2, 2020

Conversation

liljonnystyle
Copy link
Collaborator

@liljonnystyle liljonnystyle commented Jul 2, 2020 •
edited
Loading

Pull request information

  • Status: ready to merge
  • Kind of changes: new feature

Description

This PR allows the time-space diagrams to include a greyed out area over the warmup period and ghost cells. E.g.,

for single-lane straight road:
flow_858bc7a51d9f4169872cdc41d20a5cba

for I-210 subnetwork without ramps:
flow_eb49bb434d37433bbb8cf6a37463407f

eugenevinitsky
eugenevinitsky approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@eugenevinitsky eugenevinitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Thanks!

@liljonnystyle liljonnystyle changed the title Jl tsd mask Time-Space Diagram greyed regions Jul 2, 2020
@liljonnystyle liljonnystyle merged commit 06ff2d9 into i210_dev Jul 2, 2020
@liljonnystyle liljonnystyle deleted the jl-tsd-mask branch July 2, 2020 04:50
@liljonnystyle liljonnystyle restored the jl-tsd-mask branch July 2, 2020 05:22
@liljonnystyle liljonnystyle deleted the jl-tsd-mask branch July 2, 2020 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugenevinitsky eugenevinitsky eugenevinitsky approved these changes

@AboudyKreidieh AboudyKreidieh Awaiting requested review from AboudyKreidieh AboudyKreidieh is a code owner

@cathywu cathywu Awaiting requested review from cathywu cathywu is a code owner

@kanaadp kanaadp Awaiting requested review from kanaadp kanaadp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liljonnystyle @eugenevinitsky