Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup to the multi-agent trainer #971

Merged
merged 3 commits into from
Jun 18, 2020

Conversation

AboudyKreidieh
Copy link
Member

Pull request information

  • Status: ? (ready to merge / in development)
  • Kind of changes: ? (bug fix / new feature / documentation...)
  • Related PR or issue: ? (optional)

Description

? (general description)

Comment on lines 57 to 61
if WANT_DOWNSTREAM_BOUNDARY:
NET_TEMPLATE = os.path.join(
config.PROJECT_PATH,
"examples/exp_configs/templates/sumo/i210_with_ghost_cell_with_"
"downstream.xml")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be WANT_DOWNSTREAM_BOUNDARY and WANT_GHOST_CELL?

Copy link
Member

@eugenevinitsky eugenevinitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus comment

@eugenevinitsky eugenevinitsky merged commit 5ac9828 into i210_dev Jun 18, 2020
@eugenevinitsky eugenevinitsky deleted the ak/i210-multiagent-trainer branch June 18, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants