Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements update #963

Merged
merged 5 commits into from
Jul 8, 2020
Merged

Requirements update #963

merged 5 commits into from
Jul 8, 2020

Conversation

AboudyKreidieh
Copy link
Member

@AboudyKreidieh AboudyKreidieh commented Jun 11, 2020

Pull request information

  • Status: in development
  • Kind of changes: package versioning upgrades
  • Related PR or issue: None

Description

This PR updates the package version in the requirements.txt environment.yml files to match those located in i210_dev. One notable difference is the choice of tensorflow version, which I set to 1.15.2 to match h-baselines.

Currently, tests are failing for the following reasons:

  • bug 1
======================================================================

ERROR: test_visualizer_multi (tests.fast_tests.test_visualizers.TestVisualizerRLlib)

Test for multi-agent visualization

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/flow-project/flow/tests/fast_tests/test_visualizers.py", line 53, in test_visualizer_multi

    visualizer_rllib(pass_args)

  File "/home/travis/build/flow-project/flow/flow/visualize/visualizer_rllib.py", line 62, in visualizer_rllib

    pkl = get_rllib_pkl(result_dir)

  File "/home/travis/build/flow-project/flow/flow/utils/rllib.py", line 222, in get_rllib_pkl

    config = cloudpickle.load(f)

_pickle.UnpicklingError: NEWOBJ class argument isn't a type object
  • bug 2
======================================================================

ERROR: test_visualizer_single (tests.fast_tests.test_visualizers.TestVisualizerRLlib)

Test for single agent

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/flow-project/flow/tests/fast_tests/test_visualizers.py", line 35, in test_visualizer_single

    visualizer_rllib(pass_args)

  File "/home/travis/build/flow-project/flow/flow/visualize/visualizer_rllib.py", line 155, in visualizer_rllib

    agent.restore(checkpoint)

  File "/home/travis/miniconda/envs/flow/lib/python3.7/site-packages/ray/tune/trainable.py", line 341, in restore

    self._restore(checkpoint_path)

  File "/home/travis/miniconda/envs/flow/lib/python3.7/site-packages/ray/rllib/agents/trainer.py", line 559, in _restore

    self.__setstate__(extra_data)

  File "/home/travis/miniconda/envs/flow/lib/python3.7/site-packages/ray/rllib/agents/trainer_template.py", line 161, in __setstate__

    Trainer.__setstate__(self, state)

  File "/home/travis/miniconda/envs/flow/lib/python3.7/site-packages/ray/rllib/agents/trainer.py", line 855, in __setstate__

    self.workers.local_worker().restore(state["worker"])

  File "/home/travis/miniconda/envs/flow/lib/python3.7/site-packages/ray/rllib/evaluation/rollout_worker.py", line 712, in restore

    self.policy_map[pid].set_state(state)

  File "/home/travis/miniconda/envs/flow/lib/python3.7/site-packages/ray/rllib/policy/policy.py", line 250, in set_state

    self.set_weights(state)

  File "/home/travis/miniconda/envs/flow/lib/python3.7/site-packages/ray/rllib/policy/tf_policy.py", line 269, in set_weights

    return self._variables.set_weights(weights)

  File "/home/travis/miniconda/envs/flow/lib/python3.7/site-packages/ray/experimental/tf_utils.py", line 186, in set_weights

    self.assignment_nodes[name] for name in new_weights.keys()

AttributeError: 'numpy.ndarray' object has no attribute 'keys'

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6866

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 36 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.05%) to 88.884%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flow/visualize/visualizer_rllib.py 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
flow/utils/rllib.py 1 93.86%
flow/visualize/visualizer_rllib.py 1 79.27%
flow/core/kernel/vehicle/traci.py 2 88.05%
flow/envs/multiagent/ring/wave_attenuation.py 32 70.09%
Totals Coverage Status
Change from base Build 6861: -0.05%
Covered Lines: 9587
Relevant Lines: 10786

💛 - Coveralls

Copy link
Member

@eugenevinitsky eugenevinitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AboudyKreidieh AboudyKreidieh merged commit b40e435 into master Jul 8, 2020
@AboudyKreidieh AboudyKreidieh deleted the requirements-update branch July 8, 2020 19:22
liljonnystyle added a commit that referenced this pull request Jul 11, 2020
* implement HighwayNetwork for Time-Space Diagrams (#979)

* fixed h-baselines bug (#982)

* Replicated changes in 867. Done bug (#980)

* Aimsun changes minus reset

* removed crash attribute

* tensorflow 1.15.2

* merge custom output and failsafes to master (#981)

* add write_to_csv() function to master

* include pipeline README.md

* add data pipeline __init__

* add experiment.py changes

* add write_to_csv() function to master

* change warning print to ValueError message

* update to new update_accel methods

* add display_warnings boolean

* add get_next_speed() function to base vehicle class

* revert addition of get_next_speed

* merge custom output and failsafes to master

* add write_to_csv() function to master

* add display_warnings boolean

* add get_next_speed() function to base vehicle class

* revert addition of get_next_speed

* revert change to get_feasible_action call signature

* change print syntax to be python3.5 compliant

* add tests for new failsafe features

* smooth default to True

* rearrange raise exception for test coverage

* moved simulation logging to the simulation kernel (#991)

* add 210 edgestarts for backwards compatibility (#985)

* fastforward PR 989

* fix typo

* Requirements update (#963)

* updated requirements.txt and environment.yml

* Visualizer tests fixes

* remove .func

* move all miles_per_* rewards to instantaneous_mpg

* update reward fns to new get_accel() method

* made tests faster

* some fixes to utils

* change the column order, modify the pipeline to use SUMO emission file

* write metadata to csv

* change apply_acceleration smoothness setting

* make save_csv return the file paths

Co-authored-by: AboudyKreidieh <[email protected]>
Co-authored-by: liljonnystyle <[email protected]>
Co-authored-by: Kathy Jang <[email protected]>
Co-authored-by: Nathan Lichtlé <[email protected]>
Co-authored-by: akashvelu <[email protected]>
Co-authored-by: Brent Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants