Update lane change mode #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yasharzf
requested review from
AboudyKreidieh,
cathywu,
eugenevinitsky and
kanaadp
as code owners
flow/core/params.py
Outdated
Comment on lines
920
to
922
| * "no_lc_safe" (default): Disable all autonomous changing but still | ||
| handle safety checks (collision avoidance and safety-gap enforcement) | ||
| in the simulation. Binary is [001000000000] |
There was a problem hiding this comment.
We need to be careful about the word autonomous, this implies to me that the AVs cannot lane change. I think it's worth expanding the text here to be clearer about the effects.
There was a problem hiding this comment.
I think if you say "disable all SUMO lane changing" that might be good
flow/core/params.py
Outdated
Comment on lines
927
to
928
| * "sumo_default": Execute all changes unless in conflict with TraCI. | ||
| Binary is [011001010101]. |
There was a problem hiding this comment.
nit: can you make clear what "all" refers to?
Pull Request Test Coverage Report for Build 6309
💛 - Coveralls |
AboudyKreidieh
approved these changes
Jun 10, 2020
|
@eugenevinitsky I've addressed your comments in this PR. everything else looks good to me, let me know if you'd like to address anything else before we merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing lane change modes are ambiguous and misleading. For instance, "strategic" lane change mode description says "Human cars make lane changes in accordance with SUMO to provide speed boosts" however, the assigned bitset is 1621 which is SUMO's default lane change mode (execute all changes unless in conflict with TraCI). Or the bitset for "aggressive" mode is 0 which in addition to deactivating safety checks, deactivates all lane changes. I added additional lane change modes.