Add MPG reward #931
Merged
Add MPG reward #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenevinitsky
requested review from
AboudyKreidieh,
cathywu and
kanaadp
as code owners
eugenevinitsky
force-pushed
the
mpg_reward
branch
from
72a93e3 to
429df10
Compare
Yasharzf
reviewed
May 14, 2020
| """Calculate power consumption of a vehicle. | ||
| Assumes vehicle is an average sized vehicle. | ||
| The power calculated here is the lower bound of the actual power consumed | ||
| by a vehicle. |
There was a problem hiding this comment.
add description of parameters and returns
|
|
||
| accel = abs(speed - prev_speed) / env.sim_step | ||
|
|
||
| power += M * speed * accel + M * g * Cr * speed + 0.5 * rho * A * Ca * speed ** 3 |
There was a problem hiding this comment.
do you have a reference especially for some of the coefficients (e.g., Cr)? if yes, you can add it to the docstring
There was a problem hiding this comment.
No, they're from Joy and are custom values
| """Calculate miles per mega-joule of either a particular vehicle or the total average of all the vehilces. | ||
| Assumes vehicle is an average sized vehicle. | ||
| The power calculated here is the lower bound of the actual power consumed | ||
| by a vehicle. |
flow/core/rewards.py
Outdated
| # meters / joule is (v * \delta t) / (power * \delta t) | ||
| mpj = speed / power | ||
| else: | ||
| for veh_id in env.k.vehicle.get_ids(): |
There was a problem hiding this comment.
shouldn't you iterate over vehicle.get_ids() if veh_id is None? here veh_id can be a list, shouldn't you iterate over veh_id list?
| """Calculate mpg of either a particular vehicle or the total average of all the vehilces. | ||
| Assumes vehicle is an average sized vehicle. | ||
| The power calculated here is the lower bound of the actual power consumed | ||
| by a vehicle. |
| mpj = 0 | ||
| counter = 0 | ||
| if not isinstance(veh_id, list): | ||
| speed = env.k.vehicle.get_speed(veh_id) |
There was a problem hiding this comment.
what happens if veh_id is None?
There was a problem hiding this comment.
that'd be a higher up error. I can add an assert
| mpg = 0 | ||
| counter = 0 | ||
| if not isinstance(veh_id, list): | ||
| speed = env.k.vehicle.get_speed(veh_id) |
There was a problem hiding this comment.
same, if veh_id is None?
flow/core/rewards.py
Outdated
| # meters / gallon is (v * \delta t) / (gallons_s * \delta t) | ||
| mpg = speed / gallons_per_s | ||
| else: | ||
| for veh_id in env.k.vehicle.get_ids(): |
Pull Request Test Coverage Report for Build 5929
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an MPG and MP-joule reward