Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable setup of arguments to pass to SUMO executable #945

Open
roireshef opened this issue May 24, 2020 · 2 comments
Open

Configurable setup of arguments to pass to SUMO executable #945

roireshef opened this issue May 24, 2020 · 2 comments
Assignees

Comments

@roireshef
Copy link
Contributor

Feature Description

Please provide:

flow.core.kernel.simulation.traci.TraCISimulation has start_simulation method that spawns a SUMO instance. The configuration of arguments passed to the sumo instance is not exposed to the developer, and we need to go and change library code, which is not a good practice IMHO. Just like:

            # command used to start sumo
            sumo_call = [
                sumo_binary, "-c", scenario.cfg,
                "--remote-port", str(sim_params.port),
                "--num-clients", str(sim_params.num_clients),
                "--step-length", str(sim_params.sim_step)
            ]

I suggest movinga any and all SUMO executable parameters to some default configuration class (SimParams would be a good candidate) and expose it to users.

Thanks!

@eugenevinitsky
Copy link
Member

Oh yeah, this is a good idea!

@eugenevinitsky eugenevinitsky self-assigned this May 25, 2020
@roireshef
Copy link
Contributor Author

Anyone working on that? Is there any expected timeframe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants