Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sumo emissions are missing #1006

Open
temetski opened this issue Jul 18, 2020 · 1 comment
Open

Sumo emissions are missing #1006

temetski opened this issue Jul 18, 2020 · 1 comment
Labels

Comments

@temetski
Copy link
Contributor

Bug Description

PR #981 made changes to how flow generates emissions. This looks to me like emissions (in the flow sense) is essentially a datalogger of vehicle states (such as positions, headways, leader_ids, etc). SUMO, on the other hand, uses the emissions output to also dump information about vehicle emissions: NOx, PM, HC, fuel, etc.

I want to ask if SUMO's emissions are still relevant to flow in general. One particular use case I'm looking at is in the context of the impact of different vehicle types (and different emissionClasses) on vehicle emissions. If so, should 2 approaches be maintained: 1) let Sumo generate the emission files, and 2) let flow generate a custom emission file?
If 2) is the preferred direction, perhaps there should be a method that lets users pick what data to store.

The changes in #981 should have failed TestEmissionToCSV, but as this test uses a static XML as the basis for emission_to_csv, the test currently passes.

Screenshots

Screenshots:
old emissions have these headers
image

new emissions have different headers
image

Versions

  • Flow version: 0.5.0.dev
  • Flow commit number: 8a935a8
@temetski temetski added the bug label Jul 18, 2020
@temetski
Copy link
Contributor Author

Alternatively, solving #945 also resolves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant