[CORE] Add Teslamate integration #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome stuff! Thanks for your work on this! |
flosoft
requested changes
Jul 25, 2024
There was a problem hiding this comment.
Let's remove this file. We could instead add a docker-compose.yml.teslamate example including TeslaETA.
There was a problem hiding this comment.
Indeed, it was used for my development only and got committed by mistake.
| elif name == "teslamate": | ||
| return teslamate.TeslamateBackendProvider(base_url, car_id) | ||
| else: | ||
| raise Exception(f"Unknown backend provider : {name}. Available choices are 'teslalogger' or 'teslamagte'.") |
There was a problem hiding this comment.
Good catch with the typo, will fix it.
flosoft
added a commit
that referenced
this pull request
Aug 5, 2024
|
Sorry I just received the notification about it being merged. Thanks! |
Zegorax
added a commit
to Zegorax/TeslaETA
that referenced
this pull request
Aug 10, 2024
This reverts commit 13af057.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ciao,
Hope you're doing well!
You can find in this PR an integration with Teslamate in addition to Teslalogger. It's using the Factory pattern and interface extensions to have a clean code and working regardless of what the backend provider is.
I made a little modification regarding the distance mechanism. I've changed the check and instead of relying on the distance, it will check whether there is a "fixed" lat/long in the shared link DB (The form allows the creation without one). Therefore, if there is nothing, it will use the destination set in the Tesla.
Feel free to review it and don't hesitate to ask me if you have any question :)
And of course, please test it extensively!