This repository has been archived by the owner on Jun 15, 2024. It is now read-only.
Fixed bug when fetching new revision fails (throws exception etc) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revision would be replaced by nil, so the pipeline would always trigger after a failed revision fetch
|
Good catch, thanks! Could you add a test for this? |
… nil if fetching of commit failed
|
Testing this was a bit tricky, but this should do it. |
|
Looks good, merging. Thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the loop in "wait-for-revision-changed" would always recur with whatever revision was fetched, if the fetch fails, it recurs with the last seen revision as nil. This means that whenever a fetch fails, on the next poll the pipeline will trigger (even if there was no actual change). The recur only happens when the fetch has either failed or the revision has stayed the same, so recurring with the last seen revision should be fine and it fixes the problem.