Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break clang-tidy #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

break clang-tidy #30

wants to merge 1 commit into from

Conversation

florian-kuebler
Copy link
Owner

No description provided.

orbitprofiler-bot
orbitprofiler-bot reviewed Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@orbitprofiler-bot orbitprofiler-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

src/DataViews/CallstackDataView.cpp
columns[kColumnModule] = {"Module", .0f, SortingOrder::kAscending};
columns[kColumnAddress] = {"Sampled Address", .0f, SortingOrder::kAscending};
return columns;
std::vector<Column> resultingColumns_;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for local variable resultingColumns_

Suggested change
std::vector<Column> resultingColumns_;
std::vector<Column> resulting_columns;

src/DataViews/CallstackDataView.cpp
columns[kColumnAddress] = {"Sampled Address", .0f, SortingOrder::kAscending};
return columns;
std::vector<Column> resultingColumns_;
resultingColumns_.resize(kNumColumns);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for local variable resultingColumns_

Suggested change
resultingColumns_.resize(kNumColumns);
resulting_columns.resize(kNumColumns);

src/DataViews/CallstackDataView.cpp
return columns;
std::vector<Column> resultingColumns_;
resultingColumns_.resize(kNumColumns);
resultingColumns_[kColumnSelected] = {"Hooked", .0f, SortingOrder::kDescending};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for local variable resultingColumns_

Suggested change
resultingColumns_[kColumnSelected] = {"Hooked", .0f, SortingOrder::kDescending};
resulting_columns[kColumnSelected] = {"Hooked", .0f, SortingOrder::kDescending};

src/DataViews/CallstackDataView.cpp
std::vector<Column> resultingColumns_;
resultingColumns_.resize(kNumColumns);
resultingColumns_[kColumnSelected] = {"Hooked", .0f, SortingOrder::kDescending};
resultingColumns_[kColumnName] = {"Function", .65f, SortingOrder::kAscending};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for local variable resultingColumns_

Suggested change
resultingColumns_[kColumnName] = {"Function", .65f, SortingOrder::kAscending};
resulting_columns[kColumnName] = {"Function", .65f, SortingOrder::kAscending};

src/DataViews/CallstackDataView.cpp
resultingColumns_.resize(kNumColumns);
resultingColumns_[kColumnSelected] = {"Hooked", .0f, SortingOrder::kDescending};
resultingColumns_[kColumnName] = {"Function", .65f, SortingOrder::kAscending};
resultingColumns_[kColumnSize] = {"Size", .0f, SortingOrder::kAscending};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for local variable resultingColumns_

Suggested change
resultingColumns_[kColumnSize] = {"Size", .0f, SortingOrder::kAscending};
resulting_columns[kColumnSize] = {"Size", .0f, SortingOrder::kAscending};

src/DataViews/CallstackDataView.cpp
resultingColumns_[kColumnSelected] = {"Hooked", .0f, SortingOrder::kDescending};
resultingColumns_[kColumnName] = {"Function", .65f, SortingOrder::kAscending};
resultingColumns_[kColumnSize] = {"Size", .0f, SortingOrder::kAscending};
resultingColumns_[kColumnModule] = {"Module", .0f, SortingOrder::kAscending};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for local variable resultingColumns_

Suggested change
resultingColumns_[kColumnModule] = {"Module", .0f, SortingOrder::kAscending};
resulting_columns[kColumnModule] = {"Module", .0f, SortingOrder::kAscending};

src/DataViews/CallstackDataView.cpp
resultingColumns_[kColumnName] = {"Function", .65f, SortingOrder::kAscending};
resultingColumns_[kColumnSize] = {"Size", .0f, SortingOrder::kAscending};
resultingColumns_[kColumnModule] = {"Module", .0f, SortingOrder::kAscending};
resultingColumns_[kColumnAddress] = {"Sampled Address", .0f, SortingOrder::kAscending};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for local variable resultingColumns_

Suggested change
resultingColumns_[kColumnAddress] = {"Sampled Address", .0f, SortingOrder::kAscending};
resulting_columns[kColumnAddress] = {"Sampled Address", .0f, SortingOrder::kAscending};

src/DataViews/CallstackDataView.cpp
resultingColumns_[kColumnSize] = {"Size", .0f, SortingOrder::kAscending};
resultingColumns_[kColumnModule] = {"Module", .0f, SortingOrder::kAscending};
resultingColumns_[kColumnAddress] = {"Sampled Address", .0f, SortingOrder::kAscending};
return resultingColumns_;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for local variable resultingColumns_

Suggested change
return resultingColumns_;
return resulting_columns;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbitprofiler-bot orbitprofiler-bot orbitprofiler-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-kuebler @orbitprofiler-bot