Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python versions and introduce type hints #17

Merged
merged 17 commits into from
Dec 22, 2023

Conversation

lewisblake
Copy link
Contributor

@lewisblake lewisblake commented Dec 19, 2023

Hi Florian,

Hope you're doing well.

I'm opening this PR for a few things:

  • to bump up the Python versions to those that are currently active
  • introduce some type hinting which should help making the code a little easier to understand upon reading
  • change CI to run on all branches upon pulls/pushes and also in a cron job each month

Happy for feedback!

Best,
Lewis

Copy link
Collaborator

@florzg florzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@lewisblake
Copy link
Contributor Author

Of course! I think you may need to approve from your @florafauna account though - merging is blocked for me. Also, maybe we should tag a new version after these updates? I updated the version in setup.py to v0.1.3.

@florafauna florafauna merged commit 8325e24 into florafauna:master Dec 22, 2023
6 checks passed
@florafauna
Copy link
Owner

v0.1.3 released on pypi.org. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants