Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for embind and enable emscripten cmake modules #226

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

@floooh
Copy link
Owner

floooh commented Jun 20, 2019

Thanks, going to merge and test this now.

Is there any procedure to follow to get them added to https://github.com/fips-libs ?

One option is that I invite you to the fips-libs org, and you can fork those projects into fips-libs yourself. I would prefer this because this would simplify maintenance (such as if updating the git submodules is needed).

The other option is that I fork those myself into the fips-libs project, but any updates would need to be handled via PRs then.

I'll send you an invite, feel free to ignore :)

@floooh floooh merged commit eaa9443 into floooh:master Jun 20, 2019
@GeertArien
Copy link
Author

One option is that I invite you to the fips-libs org, and you can fork those projects into fips-libs yourself. I would prefer this because this would simplify maintenance (such as if updating the git submodules is needed).

The other option is that I fork those myself into the fips-libs project, but any updates would need to be handled via PRs then.

I'll send you an invite, feel free to ignore :)

Thanks for the invite :)

I'll take care of forking those projects myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants