Rewire cmake internals for cmake's target_source() #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aardappel
approved these changes
Nov 28, 2020
|
Yeah it's a weird feature indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of delaying the cmake target creating the the
fips_end_*()function, an empty target is now created in thefips_begin_*()macros, and adding sources, options, dependencies etc is now directly to the respective cmaketarget_*()functions instead of first gathering everything in variables. This simplifies the cmake scripts quite a bit and allows to directly use standard cmake commands (liketarget_sources()ortarget_compile_options()inside the fips begin/end block.