deps pinning prototype 1 (#146) #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try to set aside some time and play around with this early next week. I think it would make sense to have a separate command to create a snapshot file (./fips pin or ./fips lock). And then may be when the imports are read (e.g. here: https://github.com/floooh/fips/blob/master/mod/dep.py#L99) it would check if such a snapshot file exists in the top level repository, and fix up any revs in the imports dictionary with the revs from this file... This way fips fetch and fips update should automatically do the right thing... (at least that's the idea) ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe something like this? wdyt?