🐛 Play nice with other plugins including Play Services libraries #645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way cordova-android plugins specify their framework dependencies there is a chance that a plugin will pin an earlier version of play services and it will cause issues for other plugins requiring a later version of play services.
In order to allow end users to specify the version of frameworks in their config.xml file and free up plugin maintainers from having to release a new version of the plugin every time play services updates we introduced variables in the framework tag in cordova 7.1.0.
This PR updates the plugin.xml to use a variable for the play-services-ads dependency. This way users can match the play services versions across all plugins. With this PR merged folks will be able to:
This way both plugins will compile with play services 15 and not cause any run time errors.
Sorry for the whitespace changes in
plugin.xml
, Prettier did it.See: phonegap/phonegap-plugin-push#2360