Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show correct summon shortcut #1369

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Show correct summon shortcut #1369

merged 4 commits into from
Feb 16, 2023

Conversation

goosewobbler
Copy link
Contributor

@goosewobbler goosewobbler commented Jan 20, 2023 •
edited
Loading

Different keyboard layouts have different keys mapped for the / key. We can use navigator.keyboard.getLayoutMap to detect the key mapped to / at runtime and adjust our messaging (in the settings panel and onboarding) accordingly.

TODO:

  • Detect key layout
  • Test settings panel
  • Test onboard

@goosewobbler goosewobbler added WIP PRs that are still in progress and not ready for review or merging accessibility labels Jan 20, 2023
@goosewobbler goosewobbler modified the milestones: post-omnichain release, v0.6.0 Jan 24, 2023
@goosewobbler goosewobbler removed this from the v0.6.0 milestone Jan 26, 2023
@goosewobbler goosewobbler mentioned this pull request Jan 29, 2023
Closed
@floating floating requested a review from mholtzman February 15, 2023 18:13
@floating floating merged commit fb5ef31 into develop Feb 16, 2023
@goosewobbler goosewobbler removed the WIP PRs that are still in progress and not ready for review or merging label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholtzman mholtzman mholtzman approved these changes

Assignees
No one assigned
Labels
accessibility window management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goosewobbler @mholtzman @floating