Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows icon for Send Dapp #1095

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Fix windows icon for Send Dapp #1095

merged 2 commits into from
Oct 14, 2022

Conversation

goosewobbler
Copy link
Contributor

@goosewobbler goosewobbler commented Oct 12, 2022

Fixing the send dapp icon display issue. Tested as working with production and canary icons on Win10.

To test / reproduce (Win10):

  • Copy icon files from production Frame into build/icons
  • Build and run Frame
  • Open the send dapp
  • Observe cut-off icon for the send dapp in the taskbar

Reference for approach:
electron-userland/electron-builder#2128 (comment)

@goosewobbler goosewobbler changed the base branch from 0.5 to develop October 12, 2022 20:48
@socket-security
Copy link

socket-security bot commented Oct 12, 2022

Socket Security Report

👍 No new dependency issues detected in pull request

Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ✅ no new install scripts
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

@goosewobbler goosewobbler changed the title Fix windows icon Fix windows icon for Send Dapp Oct 12, 2022
@goosewobbler goosewobbler merged commit 55d3908 into develop Oct 14, 2022
@goosewobbler goosewobbler deleted the fix-windows-icon branch October 14, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants