Doesn't work with '-useLegacyAOT no'

[johnstejskal]

I can only get this Library to work with standard compiling, when using the new quick compile with '-useLegacyAOT no' gestures no longer work.

This is fine, but with large projects which can take up to 1 hour to compile, it becomes a problem. Is there anyway to have this library work with the quick compile?

[fljot]

That's for iOS packaging, right? Then I can't test anymore – don't have certificates and everything..

You can try debugging yourself starting with
https://github.com/fljot/Gestouch/blob/master/src/org/gestouch/core/Gestouch.as#L30
then
https://github.com/fljot/Gestouch/blob/master/src/org/gestouch/input/NativeInputAdapter.as#L70
then
https://github.com/fljot/Gestouch/blob/master/src/org/gestouch/input/NativeInputAdapter.as#L144
and so on...

It should be very easy once you find where the chain is broken.
Maybe might be related to mushroom operator issue introduced in ASC 2.0 compiler?

[remunizz]

It looks like GestureState const items are interpreted as the same object, in _initClass function "POSSIBLE.setValidNextStates(RECOGNIZED, BEGAN, FAILED);" RECOGNIZED, BEGAN, FAILED its the same static object.

My solution:
in org.gestouch.core.GestureState i changed:
"public static const POSSIBLE:GestureState = new GestureState("POSSIBLE");
public static const RECOGNIZED:GestureState = new GestureState("RECOGNIZED", true);
public static const BEGAN:GestureState = new GestureState("BEGAN");
public static const CHANGED:GestureState = new GestureState("CHANGED");
public static const ENDED:GestureState = new GestureState("ENDED", true);
public static const CANCELLED:GestureState = new GestureState("CANCELLED", true);
public static const FAILED:GestureState = new GestureState("FAILED", true);"

to:
"private static var cls:Class = GestureState;
public static const POSSIBLE:GestureState = new cls("POSSIBLE") as GestureState;
public static const RECOGNIZED:GestureState = new cls("RECOGNIZED", true) as GestureState;
public static const BEGAN:GestureState = new cls("BEGAN") as GestureState;
public static const CHANGED:GestureState = new cls("CHANGED") as GestureState;
public static const ENDED:GestureState = new cls("ENDED", true) as GestureState;
public static const CANCELLED:GestureState = new cls("CANCELLED", true) as GestureState;
public static const FAILED:GestureState = new cls("FAILED", true) as GestureState;"

look at: http://helpx.adobe.com/flash-builder/actionscript-compiler-backward-compatibility.html
to understand the changes of the new compiler.

[fljot]

@remunizz
Kudos for the finding!
So you've tested, that change totally did the trick?

[johnstejskal]

@fljot An update to the latest AIR SDK (4.6) also fixed this issue,
The issue was initially experienced in AIR 4.0

[fljot]

@johnstejskal latest AIR SDK is 14. Was that typo?

@remunizz @johnstejskal so I'm confused, should I make any changes or it works fine with the latest SDK and compiler?

[johnstejskal]

My apologies, yes AIR 14 is working with 'useLegacyAOT no'

[remunizz]

@fljot @johnstejskal Yes, My fix is for earlier versions of AIR 14,
i will update my IDE, up AIR SDK to 14 and post the results, thanks for the update.

[jonathonpitman]

This seems to be broken again in AIR 16. I need to update an app for 64 Bit Support and this fix isn't working :(

Does anyone know of a fix for AIR 16 ?

Any help is appreciated.

[fljot]

@jonathonpitman as I said before, I can't test that. But there was another problem related to GestureState static initialization recently #71 which is solvable, but still.. maybe I should get rid of static initialization thing and do that states configuration differently.

[fljot]

@johnstejskal I summon you

[jonathonpitman]

Tried the for loop fix as well.. still doesn't work with -useLegacyAOT no :(

[fljot]

@jonathonpitman ok as a first quickfix option I recommend you to try to replace const with var and create those in _initClass() method. If won't work – we need to move those static constants into different class.

[jonathonpitman]

in which file do I need to do this ?

[fljot]

GestureState we are talking about

[jonathonpitman]

You mean change for example

public static const POSSIBLE:GestureState = new cls("POSSIBLE") as GestureState;

to

public static var POSSIBLE:GestureState = new cls("POSSIBLE") as GestureState;

What do I put in the _initClass ?

[fljot]

@jonathonpitman yes, const to var, but then you put new ... into _initClass()

[jonathonpitman]

LIke

public static var POSSIBLE:GestureState;

then

POSSIBLE = new cls("POSSIBLE") as GestureState;

Like that ?

[jonathonpitman]

No errors .. this is what I have changed... still doesnt work though.

package org.gestouch.core
{
import flash.utils.Dictionary;
import flash.errors.IllegalOperationError;

/**
 * @author Pavel fljot
 */
final public class GestureState
{

    private static var cls:Class = GestureState;
    public static var POSSIBLE:GestureState;
    public static var RECOGNIZED:GestureState;
    public static var BEGAN:GestureState;
    public static var CHANGED:GestureState;
    public static var ENDED:GestureState;
    public static var CANCELLED:GestureState;
    public static var FAILED:GestureState;

    private static var allStatesInitialized:Boolean;


    private var name:String;
    private var eventType:String;
    private var validTransitionStateMap:Dictionary = new Dictionary();

    {
        _initClass();
    }


    public function GestureState(name:String, isEndState:Boolean = false)
    {
        if (allStatesInitialized)
        {
            throw new IllegalOperationError("You cannot create gesture states." +
            "Use predefined constats like GestureState.RECOGNIZED");
        }

        this.name = "GestureState." + name;
        this.eventType = "gesture" + name.charAt(0).toUpperCase() + name.substr(1).toLowerCase();
        this._isEndState = isEndState;
    }


    private static function _initClass():void
    {

    POSSIBLE = new cls("POSSIBLE") as GestureState;
    RECOGNIZED = new cls("RECOGNIZED", true) as GestureState;
    BEGAN = new cls("BEGAN") as GestureState;
    CHANGED = new cls("CHANGED") as GestureState;
    ENDED = new cls("ENDED", true) as GestureState;
    CANCELLED = new cls("CANCELLED", true) as GestureState;
    FAILED = new cls("FAILED", true) as GestureState;



        POSSIBLE.setValidNextStates(RECOGNIZED, BEGAN, FAILED);
        RECOGNIZED.setValidNextStates(POSSIBLE);
        BEGAN.setValidNextStates(CHANGED, ENDED, CANCELLED);
        CHANGED.setValidNextStates(CHANGED, ENDED, CANCELLED);
        ENDED.setValidNextStates(POSSIBLE);
        FAILED.setValidNextStates(POSSIBLE);
        CANCELLED.setValidNextStates(POSSIBLE);

        allStatesInitialized = true;
    }


    public function toString():String
    {
        return name;
    }


    private function setValidNextStates(...states):void
    {
        for each (var state:GestureState in states)
        {
            validTransitionStateMap[state] = true;
        }
    }


    gestouch_internal function toEventType():String
    {
        return eventType;
    }


    gestouch_internal function canTransitionTo(state:GestureState):Boolean
    {
        return (state in validTransitionStateMap);
    }


    private var _isEndState:Boolean = false;
    gestouch_internal function get isEndState():Boolean
    {
        return _isEndState;
    }
}

}

[fljot]

What is "doesn't work" exactly? Is it the same issues as originally that constants are somehow all equal? Or what? Does _initClass() method even executed?

Try inlining static initializator (_initClass()) (see example below).

If you're short in time and need a really quickfix, try to move all constants into another class, let's say GestureStates (note the trailing s) or GestureStateEnum:

final public class GestureStates
{
    public static const POSSIBLE:GestureState = new GestureState("POSSIBLE");
    ...
    //do the static initialization method
    //or even try inline it like this
    {
        POSSIBLE.setValidNextStates(RECOGNIZED, BEGAN, FAILED);
    }
}

[fljot]

Make some effort, it's just a few calls! Cmon people, I don't have any profiles to test myself.

[jonathonpitman]

What's not working for me is that it becomes unresponsive. No touch detected. There are no errors though.

Even when debugging from iOS to the remote debugger there is no errors.

[jonathonpitman]

I am really confused here.. sorry ;(

[jonathonpitman]

Something crashes the whole app .. nothing responds once Gestouch is initialized. ... Strange that no errors are thrown though.

[fljot]

Well you have to add some logs to understand where it don't work, right?

[jonathonpitman]

I have put in trace statements. I can see that the _init function is called. So it is getting that far.

[fljot]

So, are the gesture states (constants) initialized properly?

[jonathonpitman]

Weird... Everything is working with the new public release of AIR 16

[fljot]

And this is why I'm leaving Flash platform...

[jonathonpitman]

to make matters worse... Now everything is working great in my app .. I submitted it and Apple rejected it instantly.

Invalid Binary Error

Minimum OS Version Mismatch - The minimum OS version (LC_VERSION_MIN_IPHONEOS) in the binary ('6.0') for architecture ('armv7') differs from the MinimumOSVersion ('7.0') in the Info.plist.

Ughhhh! .. It's really tooo bad. I love making apps in AIR .. it's so easy to make cross platform apps.