Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flix-tech/avro-php #75

Merged
merged 13 commits into from
May 19, 2023
Merged

Update flix-tech/avro-php #75

merged 13 commits into from
May 19, 2023

Conversation

MaurizioMoreo
Copy link
Contributor

Update needed to support PHP8.2

@MaurizioMoreo MaurizioMoreo marked this pull request as draft April 20, 2023 09:54
@tPl0ch
Copy link
Collaborator

tPl0ch commented Apr 20, 2023 •
edited
Loading

@MaurizioMoreo This is where the CI magic is happening:
https://github.com/flix-tech/schema-registry-php-client/blob/master/.github/workflows/checks.yml#L32

Would be good to add a new 8.2 target.

marko-ilic
marko-ilic reviewed Apr 20, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@MaurizioMoreo MaurizioMoreo marked this pull request as ready for review April 20, 2023 14:25
@MaurizioMoreo MaurizioMoreo mentioned this pull request Apr 20, 2023
Merged
@MaurizioMoreo
Copy link
Contributor Author

MaurizioMoreo commented Apr 26, 2023 •
edited
Loading

Are the expected ci-checks (8, --prefer-stable) and ci-checks (8, --prefer-lowest) related to testing the behaviour when we don't specify the minor version? If yes, do you think we should add it?

@marko-ilic @tPl0ch

@MaurizioMoreo
Copy link
Contributor Author

Any news on this PR @marko-ilic @tPl0ch ?

@marko-ilic
Copy link

Any news on this PR @marko-ilic @tPl0ch ?

It looks good to me, but I'm not sure who else should check/approve it

@MaurizioMoreo
Copy link
Contributor Author

It seems that only @tPl0ch can merge it, but he is a magical creature that maybe only @nick-zh can awaken 🪄 😅

@tPl0ch
Copy link
Collaborator

tPl0ch commented May 18, 2023

Hey all, I'll have time tomorrow to check it. Sorry for the delay.

@tPl0ch tPl0ch merged commit 5e579a1 into flix-tech:master May 19, 2023
@tPl0ch
Copy link
Collaborator

tPl0ch commented May 19, 2023

Released in https://github.com/flix-tech/schema-registry-php-client/releases/tag/8.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marko-ilic marko-ilic marko-ilic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaurizioMoreo @tPl0ch @marko-ilic