Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes segment export/import match_type #711

Merged
merged 3 commits into from
Feb 19, 2022
Merged

Conversation

markphelps
Copy link
Collaborator

Fixes: #710

Add missing segment match type in export/import

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #711 (33430d6) into master (7fd5490) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   82.75%   82.77%   +0.02%     
==========================================
  Files          19       19              
  Lines        1693     1695       +2     
==========================================
+ Hits         1401     1403       +2     
  Misses        246      246              
  Partials       46       46              
Impacted Files Coverage Δ
internal/ext/exporter.go 84.84% <100.00%> (+0.15%) ⬆️
internal/ext/importer.go 77.68% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd5490...33430d6. Read the comment docs.

@markphelps markphelps enabled auto-merge (squash) February 19, 2022 15:18
@markphelps markphelps merged commit d710654 into master Feb 19, 2022
@markphelps markphelps deleted the fix-segment-export-import branch February 19, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Segment.MatchType in export
2 participants