Fix: code:3 - proto: (line 1:102): invalid value for string null #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## releases/1.5 #665 +/- ##
================================================
- Coverage 83.43% 82.86% -0.58%
================================================
Files 16 17 +1
Lines 1443 1453 +10
================================================
Hits 1204 1204
- Misses 207 217 +10
Partials 32 32
Continue to review full report at Codecov.
|
markphelps
changed the title
markphelps
pushed a commit
that referenced
this pull request
Jan 27, 2022
* Fix: code:3 - proto: (line 1:102): invalid value for string null (#665) * WIP reproduce: code:3 - proto: (line 1:102): invalid value for string type: null #664 * pipefail smh * Replace github.com/golang/protobuf with google.golang.org/protobuf * just eo pipefail * fix shakedown trap * got failing test * move around * Add v1toV2MarshallerAdapter to fix backwards compatability issue * Update Changelog * Dont need to suffix here * Use node 16 * Oops forgot print body * RM this for now until come up with a better solution * Fix changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #664
Creates
V1toV2MarshallerAdapterthat reverts back to the behavior of the grpc-gateway v1 runtime marshaller which supports usingnullmap values even if not the 'correct' thing to do.See: grpc-ecosystem/grpc-gateway#2481 (comment)