Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go embed #492

Merged
merged 7 commits into from
Jun 30, 2021
Merged

Go embed #492

merged 7 commits into from
Jun 30, 2021

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Jun 29, 2021

Removes packr in favor of native go 1.16+ asset embedding

See https://blog.carlmjohnson.net/post/2021/how-to-use-go-embed/

@codecov-commenter
Copy link

Codecov Report

Merging #492 (54763d8) into master (c6f87c0) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
+ Coverage   82.49%   82.52%   +0.03%     
==========================================
  Files          16       16              
  Lines        1011     1013       +2     
==========================================
+ Hits          834      836       +2     
  Misses        144      144              
  Partials       33       33              
Impacted Files Coverage Δ
server/rule.go 71.42% <0.00%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f87c0...54763d8. Read the comment docs.

@markphelps markphelps merged commit 1a797d2 into master Jun 30, 2021
@markphelps markphelps deleted the go-embed branch June 30, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants