feat(ui): new table view for flags and segments #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3664 +/- ##
=======================================
Coverage 64.41% 64.41%
=======================================
Files 170 170
Lines 17098 17098
=======================================
Hits 11013 11013
Misses 5400 5400
Partials 685 685
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
erka
force-pushed
the
rd/ui-new-table
branch
2 times, most recently
from
2bdfa2c
to
2af1e11
Compare
Signed-off-by: Roman Dmytrenko <[email protected]>
erka
force-pushed
the
rd/ui-new-table
branch
from
2af1e11
to
38c3150
Compare
* chore: minor updates to new ui table Signed-off-by: Mark Phelps <[email protected]> * chore: icons for flag types Signed-off-by: Mark Phelps <[email protected]> * chore: add truncate to segment name Signed-off-by: Mark Phelps <[email protected]> * chore: add segment icons Signed-off-by: Mark Phelps <[email protected]> --------- Signed-off-by: Mark Phelps <[email protected]>
markphelps
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files to improve the UI components . The key changes involve the use of a new
PageHeadercomponent for better consistency in the layout, updates to the flags and segments tables.