Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update default rollout #3301

Merged
merged 9 commits into from
Jul 24, 2024
Merged

feat: Update default rollout #3301

merged 9 commits into from
Jul 24, 2024

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Jul 23, 2024

Re: #3300 (comment)
Closes: #2811

  1. Make default rollout rule work like default variant does now (via form in rule itself)
  2. Remove enabled toggle for boolean flags as it was confusing, move it to default rollout rule
  3. Move some components that were in the ui/app folder to proper places in ui/components

CleanShot 2024-07-23 at 14 18 22@2x
CleanShot 2024-07-23 at 14 18 31@2x

TODO

  • Add UI tests specific to default values
  • Add UI tests for switching tabs (Variants, Rules/Rollouts, Analytics) (I broke this previously without realizing it)

@markphelps markphelps requested a review from a team as a code owner July 23, 2024 18:22
@markphelps markphelps changed the title Update default rollout feat: Update default rollout Jul 23, 2024
@markphelps markphelps requested review from erka and arussellsaw July 23, 2024 18:23
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.18%. Comparing base (713b3c1) to head (4036653).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3301   +/-   ##
=======================================
  Coverage   64.18%   64.18%           
=======================================
  Files         168      168           
  Lines       13506    13506           
=======================================
  Hits         8669     8669           
  Misses       4174     4174           
  Partials      663      663           
Flag Coverage Δ
unittests 64.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
@markphelps markphelps added the needs docs Requires documentation updates label Jul 23, 2024
Signed-off-by: Mark Phelps <[email protected]>
Copy link
Contributor

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Jul 24, 2024
@kodiakhq kodiakhq bot merged commit 99e4307 into main Jul 24, 2024
57 checks passed
@kodiakhq kodiakhq bot deleted the update-default-rollout branch July 24, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs needs docs Requires documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow "Default Rolluot" for Boolean to be false
2 participants