Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support etag for declarative stores #3287

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

erka
Copy link
Collaborator

@erka erka commented Jul 18, 2024

related #3248

@erka erka requested a review from a team as a code owner July 18, 2024 18:24
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.24%. Comparing base (b64891e) to head (b0e05ec).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3287      +/-   ##
==========================================
+ Coverage   64.12%   64.24%   +0.11%     
==========================================
  Files         168      168              
  Lines       13392    13410      +18     
==========================================
+ Hits         8588     8615      +27     
+ Misses       4146     4137       -9     
  Partials      658      658              
Flag Coverage Δ
unittests 64.24% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erka erka force-pushed the etag-for-declarative-store branch from 8f6556b to 57854e9 Compare July 18, 2024 19:34
Signed-off-by: Roman Dmytrenko <[email protected]>
@erka erka force-pushed the etag-for-declarative-store branch from d093dd4 to 460abc9 Compare July 18, 2024 21:24
Signed-off-by: Roman Dmytrenko <[email protected]>
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks @erka

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Jul 19, 2024
@kodiakhq kodiakhq bot merged commit 05d7234 into flipt-io:main Jul 19, 2024
33 checks passed
@erka erka deleted the etag-for-declarative-store branch July 19, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants