-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): allow change top bar theme color #3128
Conversation
dad41a8
to
2f5b227
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3128 +/- ##
==========================================
+ Coverage 70.78% 71.72% +0.93%
==========================================
Files 91 106 +15
Lines 8729 7862 -867
==========================================
- Hits 6179 5639 -540
+ Misses 2165 1784 -381
- Partials 385 439 +54 ☔ View full report in Codecov by Sentry. |
6ee7387
to
8dca6e1
Compare
Signed-off-by: Roman Dmytrenko <[email protected]>
8dca6e1
to
346cedf
Compare
I don't have a good place for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick question re validation of hex colors
Signed-off-by: Roman Dmytrenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! thanks @erka
Thanks @erka ! Are you planning on adding the label to the topbar? |
@danilobuerger Thank you for reaching out. Yes, we are considering adding the label to the topbar. However, we haven't finalized the exact placement yet. If you have any preferences or suggestions on where you'd like to see it, we'd love to hear your thoughts. |
@erka Thats awesome! I don't really have a suggestion on the placement, just that it should be big and visible (for example displaying "Warning - Production"). |
closes #3080