-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): assistance for arrays data in constraints #2889
Conversation
@markphelps it isn't ready but I would like to get you feedback and thoughts. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
==========================================
+ Coverage 70.78% 72.14% +1.36%
==========================================
Files 91 92 +1
Lines 8729 7102 -1627
==========================================
- Hits 6179 5124 -1055
+ Misses 2165 1594 -571
+ Partials 385 384 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great so far @erka as usual!! Thank you for taking this on!
I know you said it wasn't ready, but I tested it and works great for the most part. Just a couple minor things I noticed:
we may want to make sure we strip certain characters like [ ]
from the strings, as above caused an error:
- we probably want to truncate the values in the UI
- we may want to play around with the colors a bit to try something lighter for the pills? wdyt?
@markphelps I've addressed all of them except the first one. I don't see any issues with special characters, maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks and works amazing @erka !!!
I tested it for backward compatibility, from the current release of Flipt which only renders the raw array |
closes #2885