Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing slash in copy as curl #2875

Merged
merged 5 commits into from
Mar 18, 2024
Merged

fix: missing slash in copy as curl #2875

merged 5 commits into from
Mar 18, 2024

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Mar 18, 2024

Fixes copy as curl URL:

curl -X POST -H "Content-Type: application/json" -H "Accept: application/json" -H "Cache-Control: no-store" -H "Authorization: Bearer <api-token>" -d '{"flagKey":"asdfasdf","entityId":"d0b0a86d-d63c-403a-a5cd-35517283992d","context":{},"namespaceKey":"default"}' https://try.flipt.ioevaluate/v1/variant

Note https://try.flipt.ioevaluate/v1/variant should be https://try.flipt.io/evaluate/v1/variant

@markphelps markphelps requested a review from a team as a code owner March 18, 2024 14:48
@markphelps markphelps requested a review from erka March 18, 2024 14:53
@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Mar 18, 2024
Copy link
Collaborator

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great.

This bug I introduced in #2723 just for the record.

@kodiakhq kodiakhq bot merged commit 93c38dc into main Mar 18, 2024
28 checks passed
@kodiakhq kodiakhq bot deleted the fix-copy-as-curl branch March 18, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants