feat: move validation into its separate package #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yquansah
force-pushed
the
validation-package
branch
from
86fc64e to
dbb053f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
GeorgeMac
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Before we make the jump, I wonder if its worth us picking a name which is a little bit more generic, as I forsee us publishing a few more things into public module space. For example, I think the yaml format itself, parsing of it and potentially building snapshots.
Maybe we make this a module called core? With a validation package in it?
…into validation-package * 'validation-package' of https://github.com/flipt-io/flipt: chore(deps): bump github.com/docker/docker in /build (#2879)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move validation into a separate package, so we can leverage the functionality outside of Flipt via a go module.