Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): replace slashes with dashes via gh workflow step #2566

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

GeorgeMac
Copy link
Member

The ITs are currently not running.
There is a bug, but GH quietly fails and doesn't run the tests.

@GeorgeMac GeorgeMac requested a review from a team as a code owner December 19, 2023 16:34
@GeorgeMac GeorgeMac enabled auto-merge (squash) December 19, 2023 16:45
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (253b8e8) 71.41% compared to head (906e11d) 71.41%.

❗ Current head 906e11d differs from pull request most recent head 8a1ebf5. Consider uploading reports for the commit 8a1ebf5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2566   +/-   ##
=======================================
  Coverage   71.41%   71.41%           
=======================================
  Files          82       82           
  Lines        8054     8054           
=======================================
  Hits         5752     5752           
  Misses       1955     1955           
  Partials      347      347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GeorgeMac GeorgeMac changed the title fix(github): there was some funky escaping breaking the workflows fix(github): replace slashes with dashes via gh workflow step Dec 19, 2023
@GeorgeMac GeorgeMac merged commit c05a807 into main Dec 19, 2023
29 checks passed
@GeorgeMac GeorgeMac deleted the gm/fix-gh-workflow branch December 19, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants