Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup header; show user name and opt login in user dropdown #2480

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Dec 3, 2023

Fixes: #2222

Note: I put the UI in ReadOnly mode to show the updated icon size/description as well as the spacing between user profile image and if readonly pill

CleanShot 2023-12-03 at 11 02 27@2x

CleanShot 2023-12-03 at 11 40 08@2x

CleanShot 2023-12-03 at 11 41 59@2x

@WDaan lmk if this is what you had in mind and I can mark it as closing the above linked issue ☝🏻

Copy link
Contributor

github-actions bot commented Dec 3, 2023

Uffizzi Ephemeral Environment deployment-42037

☁️ https://app.uffizzi.com/github.com/flipt-io/flipt/pull/2480

📄 View Application Logs etc.

⏰ This Preview will be destroyed in 1 hours at: Mon Dec 4 00:13:03 UTC 2023

What is Uffizzi? Learn more!

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (278c1bb) 70.73% compared to head (2f908f3) 70.71%.

Files Patch % Lines
internal/server/auth/method/github/server.go 25.00% 2 Missing and 1 partial ⚠️
internal/server/auth/method/oidc/server.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2480      +/-   ##
==========================================
- Coverage   70.73%   70.71%   -0.03%     
==========================================
  Files          81       81              
  Lines        8130     8134       +4     
==========================================
+ Hits         5751     5752       +1     
- Misses       2033     2035       +2     
- Partials      346      347       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WDaan
Copy link

WDaan commented Dec 3, 2023

Jup, that's exactly it. Looks way cleaner now! 😎

@markphelps markphelps merged commit d228cb0 into main Dec 4, 2023
30 of 32 checks passed
@markphelps markphelps deleted the header-ui-tweaks branch December 4, 2023 12:52
@erka
Copy link
Collaborator

erka commented Dec 4, 2023

@markphelps I am sorry to be a bit later. It took some time to get dex running in local env. There is a small issue if scopes have the email option only. The UI will look like this.

image

@markphelps
Copy link
Collaborator Author

Good catch @erka , will fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FLI-632] User Info in UI
4 participants