Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use rtk for flags #2478

Merged
merged 2 commits into from
Dec 3, 2023
Merged

refactor: use rtk for flags #2478

merged 2 commits into from
Dec 3, 2023

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Dec 2, 2023 •
edited
Loading

Fixes: #2448

  • removes SWR completely
  • moves Flags to RTK
  • removes flags API methods in data/api
  • other general cleanup

cc @erka

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2023 •
edited
Loading

Uffizzi Ephemeral Environment deployment-42020

☁️ https://app.uffizzi.com/github.com/flipt-io/flipt/pull/2478

📄 View Application Logs etc.

⏰ This Preview will be destroyed in 1 hours at: Sat Dec 2 21:35:25 UTC 2023

What is Uffizzi? Learn more!

@markphelps markphelps marked this pull request as ready for review December 2, 2023 20:27
@markphelps markphelps requested a review from a team as a code owner December 2, 2023 20:27
@codecov Codecov
Copy link

codecov bot commented Dec 2, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44e34fa) 70.73% compared to head (93b8b2e) 70.73%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2478   +/-   ##
=======================================
  Coverage   70.73%   70.73%           
=======================================
  Files          81       81           
  Lines        8130     8130           
=======================================
  Hits         5751     5751           
  Misses       2033     2033           
  Partials      346      346

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markphelps markphelps changed the title chore(wip): refactor to use rtk for flags chore: refactor to use rtk for flags Dec 3, 2023
@erka
Copy link
Collaborator

erka commented Dec 3, 2023

@markphelps it looks great!

Probably swr is a good alternative to Redux RTK. It looks similar but somehow it was lost in all other activities in the project.

I agree that it's a chore as activity but I think that refactor will be a better conventional name for this PR.

@markphelps markphelps changed the title chore: refactor to use rtk for flags refactor: use rtk for flags Dec 3, 2023
@markphelps markphelps requested a review from erka December 3, 2023 12:49
erka
erka approved these changes Dec 3, 2023
View reviewed changes
Copy link
Collaborator

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@markphelps markphelps merged commit 278c1bb into main Dec 3, 2023
32 checks passed
@markphelps markphelps deleted the flags-rtx branch December 3, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erka erka erka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: Move Flags to use RTK
2 participants
@markphelps @erka