Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pre-commit hook support #2451

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

jalaziz
Copy link
Contributor

@jalaziz jalaziz commented Nov 27, 2023

Add pre-commit hook support for flipt validate. This allows users to add a pre-commit hook that calls validates flipt feature flag configuration as part of GitOps workflows.

@jalaziz jalaziz requested a review from a team as a code owner November 27, 2023 02:44
@jalaziz jalaziz force-pushed the flipt-validate-precommit branch from 1b0a080 to 64da8ae Compare November 27, 2023 02:44
Add pre-commit hook support for flipt validate. This allows users to add
a pre-commit hook that calls validates flipt feature flag configuration
as part of GitOps workflows.
@jalaziz jalaziz force-pushed the flipt-validate-precommit branch from 64da8ae to c03ba36 Compare November 27, 2023 02:45
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (766cbcd) 70.72% compared to head (eefebd4) 70.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2451   +/-   ##
=======================================
  Coverage   70.72%   70.72%           
=======================================
  Files          81       81           
  Lines        8139     8139           
=======================================
  Hits         5756     5756           
  Misses       2036     2036           
  Partials      347      347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@markphelps markphelps added automerge Used by Kodiak bot to automerge PRs and removed automerge Used by Kodiak bot to automerge PRs labels Nov 28, 2023
@kodiakhq kodiakhq bot merged commit cb7ef66 into flipt-io:main Nov 28, 2023
29 checks passed
@jalaziz jalaziz deleted the flipt-validate-precommit branch November 29, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants